FIX JS Console errors and warnings #1698
Closed
+17
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
sabina-talipova
force-pushed
the
pulls/2/fix-js-console-errors
branch
2 times, most recently
from
19edaaf to
aa8c60a
Compare
sabina-talipova
commented
Mar 4, 2024
| this.setComponent(ReactField); | ||
| this._super(); | ||
| this.refresh(); | ||
| if (schema) { |
There was a problem hiding this comment.
In first load Entwine this.data('schema') method returns null.
sabina-talipova
commented
Mar 4, 2024
| @@ -166,12 +166,12 @@ SearchableDropdownField.propTypes = { | |||
| multi: PropTypes.bool.isRequired, | |||
| name: PropTypes.string.isRequired, | |||
| placeholder: PropTypes.string.isRequired, | |||
| onChange: PropTypes.func.isRequired, | |||
| onChange: PropTypes.func, | |||
There was a problem hiding this comment.
I don't think that this method is always required. This recommendation gives advice to use defaultProps instead of isRequired if we are not sure that this value will be provided.
sabina-talipova
commented
Mar 4, 2024
| options: PropTypes.arrayOf(PropTypes.object), | ||
| optionUrl: PropTypes.string, | ||
| passRef: PropTypes.bool.isRequired, | ||
| searchable: PropTypes.bool.isRequired, | ||
| value: PropTypes.any.isRequired, |
There was a problem hiding this comment.
Here as well. We don't have any values in a new field and pass value as null.
sabina-talipova
force-pushed
the
pulls/2/fix-js-console-errors
branch
from
aa8c60a to
1df1ee7
Compare
GuySartorelli
requested changes
Mar 5, 2024
There was a problem hiding this comment.
- Please retarget to
2.2since this is a bug that should be resolved prior to tagging 5.2.0 stable - There is still no formfield displaying. A field should be displayed (that's the main thing the issue is about - the console errors were just added to help diagnose what's causing the problem)
I haven't looked at the actual code yet, just tried locally and saw that the form field still doesn't display.
|
Close in favour of #1699 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SearchableDropdownFieldwas tested with LinkField, Elemental and simply on a Page. There are not any related errors or warnings in dev or prod.Parent issue
SearchableDropdownFielddoesn't work in form modal #1690